Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use base argument instead of series #1182

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 8, 2024

Description

  • support both 6 and 7 versions of Charms facade.
  • deprecate the series= argument
  • [to do] introduce base= argument

QA Steps

  • [to do] validate using existing integration tests

Fixes #1156

@dimaqq dimaqq force-pushed the fix-juju-3.6-deploy branch from 1025a54 to 5475732 Compare November 8, 2024 07:25
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 8, 2024

@SimonRichardson early preview: a way to support Juju 3.6.

In a nutshell:

  • use Facade v6 for old Juju (3.0 ~ 3.2.x)
    • exact same code path as before
  • use Facade v7 for new Juju (3.3.0 ~ latest)
    • drop client-side series computation, let the controller decide
    • to do: handle explicit base
  • deprecate series= kwarg

Major to do: support charms' existing integration tests against Juju 3.3.0 ~ 3.5.4

  • convert series= to base=
  • propagate this or explicit base=

@dimaqq dimaqq changed the title Fix juju 3.6 deploy feat: use base argument instead of series Nov 15, 2024
@dimaqq dimaqq force-pushed the fix-juju-3.6-deploy branch from 9a794fe to 97ef60d Compare November 19, 2024 07:49
Charms v7 no longer excluded
@Gmerold
Copy link

Gmerold commented Dec 18, 2024

Hi @dimaqq,
Do you plan to pick up this PR? It looks like its intent is exactly what my team needs for the tests to start passing ;)
Thanks!

@gatici
Copy link

gatici commented Dec 18, 2024

Hello @dimaqq,
We are having a problem similar to #1240. Currently, it is a blocker for us.
I assume this PR will fix this issues. We appreciate if you could complete it as soon as possible.
Many thanks!

@dimaqq
Copy link
Contributor Author

dimaqq commented Dec 18, 2024

I think so, either I or someone from juju. Realistically in January though.

@dimaqq
Copy link
Contributor Author

dimaqq commented Dec 18, 2024

P.S. this PR is currently very raw. It doesn’t yet solve anything. The high level direction is clear though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Juju 3.3+ bases instead of or in addition to series
3 participants