chore: dump gha for node deprecation #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-garner-canonical
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Sounds good to me.
I noticed that we still get a similar warning on cla-check
The following actions use a deprecated Node.js version and will be forced to run on node20: canonical/[email protected].
The version 1.2.3 specified here is kind of odd, since apparently the latest version is 1.1.4
|
I think you're confusing the github actions marketplace with repo tags. |
|
You're right! Looks like 1.2.3 is the latest so nothing to do there. |
|
Ugh why is GitHub unhappy about signed commits now? Looks a-ok to me! |
|
Solved by reuploading the same key to github. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the versions of 1st party github actions in CI.
Fixes #1115
Fixes warnings like this:
Linter (3.10) The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/And this:
Warning actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. Learn more. Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions. This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.Not touching download-artifact as that's sourced from someone's private repo; would have to actually check what changed there.