draft: live jrpc calls using separate event in a helper thread #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
force-pushed
the
hack-helper-thread
branch
from
0d48c3d to
148eed0
Compare
dimaqq
force-pushed
the
hack-helper-thread
branch
3 times, most recently
from
9d0928d to
28e1a44
Compare
dimaqq
force-pushed
the
hack-helper-thread
branch
from
ec9233b to
3f98b53
Compare
dimaqq
force-pushed
the
hack-helper-thread
branch
from
3f98b53 to
cb48c2e
Compare
refactor all things! demo! use both async (old) and wrapped async (new) to get same data cleanup🧼 shorter helper thread code wip note about exposed Simon says implement Application.exposed typed decorator for the win wip plain decorator works better cleanup🧼 name is entity id wip fix: missing file type up .wait_for_idle() better code style write down next steps chore: refactor jrpc response type coercion for testing chore: refactor jrpc response type coercion for testing, missing files chore: document different ways .wait_for_idle(...) may be called chore: refactor for testability chore: wip / squash me chore: clarify wait for idle params chore: clarify wait for idle params wip chore: more hookup chore: mock out everything needed for old idle loop chore: refactor test setup chore: more tests chore: start on app and unit counting mechanics chore: more app and unit counting mechanics reimplement unset status back fill chore: refactor legacy loop, fix error condition; note that status compounding is ineffective chore: refactor new loop checker, note to do chore: kidna finish the idle loop, hopefully? chore: fill in wait_for_at_least_units=N chore: wait_for_exact_units chore: exact and at least units are exclusive cleanup🧼
dimaqq
force-pushed
the
hack-helper-thread
branch
from
cb48c2e to
869b01c
Compare
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 26, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 26, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 26, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 26, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 28, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 28, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 28, 2024
dimaqq
added a commit
to dimaqq/python-libjuju
that referenced
this pull request
Nov 28, 2024
|
This branch needs to be rebased on top of main after #1219 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.