Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Juju 3.3+ bases instead of or in addition to series #1156

Open
dimaqq opened this issue Oct 10, 2024 · 2 comments · May be fixed by #1182
Open

Support Juju 3.3+ bases instead of or in addition to series #1156

dimaqq opened this issue Oct 10, 2024 · 2 comments · May be fixed by #1182
Labels
juju/4.0 kind/wishlist requested feature priority/normal normal priority

Comments

@dimaqq
Copy link
Contributor

dimaqq commented Oct 10, 2024

Description

Older Juju used "series" like "focal"
New Juju uses "bases" like "[email protected]"

See:
https://discourse.charmhub.io/t/transition-from-series-to-base-in-juju-4-0/14127
https://juju.is/docs/juju/base

Urgency

It would save from a weird workaround

Code I'd Like to Run

...
@dimaqq dimaqq added kind/wishlist requested feature priority/normal normal priority labels Oct 10, 2024
@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 10, 2024

Need to decide how we do this:

  • drop Juju 3.2 support and move all code to bases?
  • or dual-wield series and bases depending on juju controller version?

For 3.x series of this library, we have to make a table of series --> bases, like "focal" -> [email protected]

For 4.x series, we could force all users to upgrade, maybe?

@dimaqq dimaqq mentioned this issue Oct 10, 2024
Merged
@james-garner-canonical
Copy link
Contributor

For 4.x series, we could force all users to upgrade, maybe?

I think this is reasonable -- drop series entirely and only use bases in python-libjuju targeting Juju 4.0.

If no users are requesting support for bases, do we need to support them in 3.x of this library? I know that we probably should, but for example Juju 3.6 seems to still supports Charms facade version 6, which still uses series instead of bases.

Open
james-garner-canonical added a commit to james-garner-canonical/python-libjuju that referenced this issue Oct 14, 2024
@james-garner-canonical
test: bump series and pin revision for local charm refresh tests
19381a8 
A recent update to the 'ubuntu' charm requires the use of the v2
metadata format when refreshing from a local charm. The v2 format
replaces series with bases, among other changes. Properly supporting
this will need to wait on updating python-libjuju to handle bases as
well as (or instead of) series -- see issue juju#1156.

In the meantime, fix the test breakage by pinning the install of
'ubuntu' in broken tests to the previous revision (24). This revision
has a mismatch with the specification of the "focal" series (20.04), so
also bump the series in the local charm to "jammy".
Merged
jujubot added a commit that referenced this issue Oct 15, 2024
@jujubot
Merge pull request #1158 from james-garner-canonical/24.10/test/fix-l…
c040672 
…ocal-refresh-integration

#1158

#### Description

A recent update to the 'ubuntu' charm requires the use of the v2 metadata format when refreshing from a local charm. The v2 format replaces series with bases, among other changes. Properly supporting this will need to wait on updating python-libjuju to handle bases as well as (or instead of) series -- see issue #1156.

In the meantime, fix the test breakage by pinning the install of 'ubuntu' in broken tests to the previous revision (24). This revision has a mismatch with the specification of the "focal" series (20.04), so also bump the series in the local charm to "jammy".


#### QA Steps

CI tests should now pass again.
@dimaqq dimaqq linked a pull request Dec 3, 2024 that will close this issue
Draft
@dimaqq dimaqq mentioned this issue Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
juju/4.0 kind/wishlist requested feature priority/normal normal priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use base argument instead of series dimaqq/python-libjuju
2 participants
@dimaqq @james-garner-canonical