Skip to content

Commit

Permalink
ci: udpate continue markers and explain why
Browse files Browse the repository at this point in the history
  • Loading branch information
dimaqq committed Oct 17, 2024
1 parent bed9eae commit c7abedc
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
# * test_ssh
# * ...
# - "3.6/beta"
continue-on-error: false # don't ignore if tests against some juju version fail
continue-on-error: false # ultimately fail a run if one of the matrix combinations fails
steps:
- name: Check out code
uses: actions/checkout@v4
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
- name: Run integration
# Force one single concurrent test
run: tox -e integration
continue-on-error: true # so that other juju versions are tested
continue-on-error: true # don't fail early, let other matrix combinations get tested

integration-quarantine:
name: Quarantined Integration Tests
Expand All @@ -174,6 +174,7 @@ jobs:
- "3.3/stable"
- "3.4/stable"
- "3.5/stable"
continue-on-error: false # ultimately fail the run if one of the matrix combinations fails
steps:
- name: Check out code
uses: actions/checkout@v3
Expand All @@ -188,4 +189,4 @@ jobs:
juju-channel: ${{ matrix.juju }}
- name: Run integration
run: tox -e integration-quarantine
continue-on-error: true # so that other juju versions are tested
continue-on-error: true # don't fail early, let other matrix combinations get tested

0 comments on commit c7abedc

Please sign in to comment.