Remove unused functions + drop series before focal #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wish to remove the concept of a series from the juju extended codebase. Series is something that juju/packaging relies on quite heavily We can change this by removing a number of unused functions/methods which take in series as parameters. Also, since we no longer support series before focal, we can take out a lot of the special cases and make the PackingingConfigurers series agnostic
jack-w-shaw
force-pushed
the
JUJU-4948_remove_unused_series_function
branch
from
a2c4439 to
ebe0361
Compare
Done |
SimonRichardson
approved these changes
Apr 16, 2024
|
|
||
| // ubuntuToCentOSPackageNameMap is a map for converting package names from their | ||
| // names in Ubuntu repositories to their equivalent CentOS names. | ||
| var ubuntuToCentOSPackageNameMap = map[string]string{ |
There was a problem hiding this comment.
This looks like a miss-feature. We probably shouldn't have added this in the first place.
hmlanigan
approved these changes
Apr 16, 2024
3 tasks
jujubot
added a commit
to juju/juju
that referenced
this pull request
Apr 17, 2024
…n_packaging #17194 juju/packaging v3 no longer uses series in a bunch of places See the changes to juju/packaging here: juju/packaging#22 Fix places where we use function from packagings which no taek a series param This drops our external dependency on series, so start pushing bases to replace series up the stack In most places, we're blocked by HostSeries. We are soon to replace this with HostBase, which would elimate series entirely in a bunch of places ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc - [x] Comments saying why design decisions were made - [x] Go unit tests, with comments saying what you're testing ## QA steps ``` $ juju bootstrap aws aws $ juju add-model m $ juju add-machine $ juju add-machine lxd:0 $ juju add-machine lxd:0 --base [email protected] (wait) $ juju status Model Controller Cloud/Region Version SLA Timestamp m aws aws/eu-west-2 3.5-beta1.1 unsupported 13:25:13+01:00 Machine State Address Inst id Base AZ Message 0 started 18.170.114.179 i-0a1c12a72964544fe [email protected] eu-west-2c running 0/lxd/0 started 252.41.183.122 juju-d23f30-0-lxd-0 [email protected] eu-west-2c Container started 0/lxd/1 started 252.41.183.143 juju-d23f30-0-lxd-1 [email protected] eu-west-2c Container started ``` ## Links **Jira card:** https://warthogs.atlassian.net/browse/JUJU-4948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wish to remove the concept of a series from the juju extended codebase. Series is something that juju/packaging relies on quite heavily
We can change this by removing a number of unused functions/methods which take in series as parameters.
Also, since we no longer support series before focal, we can take out a lot of the special cases and make the PackingingConfigurers series agnostic
NOTE:
RequiresBackport is used in 1 place in juju/juju, but since RequiresBackport always returns false for the supported bases, we can still drop it
QA Steps
Compile into juju by checking out juju/juju#17194
NOTE: You will have to change the replace line to point to where you have clone this PR
and run
make installThen: