Correctly report valid series for juju 2.9 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
series/supportedseries.go
Outdated
| "noble": { | ||
| Version: "24.40", | ||
| LTS: true, | ||
| ESMSupported: true, |
There was a problem hiding this comment.
We have to be careful here because we can end up allowing a controller or workload being able to use noble.
There was a problem hiding this comment.
Also at the time (this is 4+ years ago) I didn't have the courage to bring on the os/series package into Juju, which would have made this so much easier to work out. Today we should 100% just bring in the os package into Juju (it's on my very long list).
There was a problem hiding this comment.
Ah yea, good point, I've changed that to false, that matches the others in there.
There was a problem hiding this comment.
Yea it defo should be brought in, I can imagine we're not even using most of it, like all this reading distroinfo stuff will not be needed at all.
Aflynn50
force-pushed
the
fix-series-version
branch
from
08b4c65 to
b0f8f3b
Compare
anvial
approved these changes
Apr 29, 2024
jujubot
added a commit
to juju/juju
that referenced
this pull request
Apr 29, 2024
#17283 <!-- Why this change is needed and what it does. --> Terraform tests require a new variable to indicate the version of juju that they are operating with. This is added to the actions yaml. This PR also brings in the fix from juju/os#49 which stops juju 2.9 supporting new distro versions it finds in distro info. The tests are updated to account for `noble`. ## Checklist <!-- If an item is not applicable, use `~strikethrough~`. --> - [x] Code style: imports ordered, good names, simple structure, etc ## QA steps CI passes
jack-w-shaw
reviewed
May 15, 2024
| Supported: false, | ||
| }, | ||
| "noble": { | ||
| Version: "24.40", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.9 new ubuntu series that appear in the distro info are automatically marked as supported. This is because in this package, when they are read out, the default is
Supported:true. This PR changes that to false. This method of determinng series is not used by any of the supported 3.x versions of Juju, only by Juju 2.9.This PR updates the supported os series supported by juju. It keeps a list of known supported versions and if a version is not in the list it is not marked as supported when it is found in the os distro-info.