Drop @cached decorator from openstack_release() #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openstack_release() function is typically called (indirectly) by os_release() which already does caching. The caching of openstack_release() was preventing updates to the value during upgrading to a new release of openstack. Closes-Bug: #2037751
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Oct 2, 2023
The was removed from upstream nova in the 2023.2 cycle via commit 5edd805fe2395f35ecdfe5b589a51dc00565852f. The nova release note states: The ``AvailabilityZoneFilter`` was deprecated for removal in 24.0.0 (Xena) and has now been removed. The functionality of the``AvailabilityZoneFilter`` has been replaced by the``map_az_to_placement_aggregate`` pre-filter. The pre-filter was introduced in 18.0.0 (Rocky) and enabled by default in 24.0.0 (Xena). This pre-filter is now always enabled and the ``[scheduler] query_placement_for_availability_zone`` config option has been removed. This change also syncs the charm-helpers change from: juju/charm-helpers#850 Closes-Bug: #2037751 Closes-Bug: #2036766 Change-Id: I315900a7e32ec66b27fa69961e9b7dcb9fa1f949
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Oct 2, 2023
* Update charm-nova-cloud-controller from branch 'master'
to f022edc81f271020a4fcba722eeda13d794b0b72
- Merge "Drop AvailabilityZoneFilter inline with upstream removal"
- Drop AvailabilityZoneFilter inline with upstream removal
The was removed from upstream nova in the 2023.2 cycle
via commit 5edd805fe2395f35ecdfe5b589a51dc00565852f.
The nova release note states:
The ``AvailabilityZoneFilter`` was deprecated for removal
in 24.0.0 (Xena) and has now been removed.
The functionality of the``AvailabilityZoneFilter`` has been
replaced by the``map_az_to_placement_aggregate`` pre-filter.
The pre-filter was introduced in 18.0.0 (Rocky) and enabled
by default in 24.0.0 (Xena). This pre-filter is now always
enabled and the ``[scheduler] query_placement_for_availability_zone``
config option has been removed.
This change also syncs the charm-helpers change from:
juju/charm-helpers#850
Closes-Bug: #2037751
Closes-Bug: #2036766
Change-Id: I315900a7e32ec66b27fa69961e9b7dcb9fa1f949
freyes
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openstack_release() function is typically called (indirectly) by os_release() which already does caching. The caching of openstack_release() was preventing updates to the value during upgrading to a new release of openstack.
Closes-Bug: #2037751