Don't filter the proxy settings being passed to curl #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env_proxy_settings() DTRT by default with no arguments. Passing 'https' as an argument just causes it to FAIL to honor no_proxy in the environment which it should.
|
@vorlonofportland please could you add a reason for why this PR is needed. e.g. is there a bug that it is fixing? Thanks. |
ajkavanagh
added
the
Incomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env_proxy_settings() DTRT by default with no arguments. Passing 'https' as an argument just causes it to FAIL to honor no_proxy in the environment which it should.