allow for specifying an offset without a limit #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offset can now be specified and used without having to specify a limit
|
Unit tests? |
| @@ -355,7 +355,7 @@ MySQL.prototype.all = function all(model, filter, callback) { | |||
| } | |||
|
|
|||
| function buildLimit(limit, offset) { | |||
| return 'LIMIT ' + (offset ? (offset + ', ' + limit) : limit); | |||
| return 'LIMIT ' + (offset ? (offset + ', ' + (limit || Math.pow(2,53))) : limit); | |||
There was a problem hiding this comment.
Couldn't Math.pow(2,53) be calculated just once and just re-use that value here instead?
|
@mscdex yeah, that would be a better way to go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offset can now be specified and used without having to specify a limit
from http://dev.mysql.com/doc/refman/5.5/en/select.html
To retrieve all rows from a certain offset up to the end of the result set, you can use some large number for the second parameter. This statement retrieves all rows from the 96th row to the last:
SELECT * FROM tbl LIMIT 95,18446744073709551615;