Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Linux: overly strict assertion on executable path prevents valid use cases #1280

Open
1 task done
jistr opened this issue Sep 26, 2023 · 0 comments
Open
1 task done

Comments

@jistr
Copy link

jistr commented Sep 26, 2023

Detailed steps on how to reproduce the bug

This assertion looks overly strict to me, requiring an absolute or relative path, but not allowing for binaries which reside on $PATH, even though later on execvp is used which should resolve the $PATH use case fine:

jassert (File::getCurrentWorkingDirectory().getChildFile (exe).existsAsFile()
|| ! exe.containsChar (File::getSeparatorChar()));

If the program is not in working dir, it is on $PATH instead, and it has been launched only using its name (e.g. helio) and not via its absolute path (e.g. /usr/bin/helio) then the assertion will fail.

The strict assertion seems to be the root cause of this issue: helio-fm/helio-sequencer#280

What is the expected behaviour?

Program on $PATH should be executable using its command name without any path components (absolute or relative).

Operating systems

Linux

What versions of the operating systems?

Fedora 38 (but i don't think it's relevant)

Architectures

x86_64

Stacktrace

No response

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

No response

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

  • I agree to follow the Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant