Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pebble to 3.2.2 and other dependencies. #1250

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Upgrade pebble to 3.2.2 and other dependencies. #1250

merged 4 commits into from
Mar 13, 2024

Conversation

igrqb
Copy link
Contributor

@igrqb igrqb commented Mar 13, 2024

Thanks for contributing.

Description

  • Upgraded io.pebbletemplates:pebble 3.1.6 -> 3.2.2
  • Updated imports in java files to reflect changes in pebble package names
  • Upgraded other dependencies
  • Added versions-maven-plugin to assist in finding dependency updates: usage mvn versions:display-dependency-updates
  • For plugin updates use mvn versions:display-plugin-updates

Testing

  • ran mvn test all tests passed

Additional notes

  • Tried to upgrade com.github.haifengl:smile-* dependencies to 3.0.1
  • Tests failed - specifically SmileConverterTest.regression
  • Downgraded back to 2.6.0 due to (simple but significant) breaking change - see commit message

@benmccann benmccann merged commit 4e471b9 into jtablesaw:master Mar 13, 2024
7 checks passed
@igrqb
Copy link
Contributor Author

igrqb commented Mar 14, 2024

Many thanks @benmccann for the merge. Any chance of releasing a new version as Sonatype is complaining about pebble: https://ossindex.sonatype.org/component/pkg:maven/io.pebbletemplates/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants