Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6 add an option to repeat animation #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ammarbinfaisal1
Copy link

Any changes required to this?

@ekremkenter
Copy link

@jstejada You should definitely merge this, it is a real use case of this library and needed.

@npupko
Copy link

npupko commented Feb 6, 2019

@jstejada Can u merge it, please? Really useful feature

@chrisabrams
Copy link

For anyone else that needs the repeat option I've published @ammarbinfaisal 's fork as react-typist-n10. You just need to add repeat as a prop on the Typist component.

@jstejada
Copy link
Owner

thanks for doing this! I'll need to think if we really need to merge this in, since there are alternatives without having to update this component itself: #6

@ohlr
Copy link

ohlr commented Mar 22, 2020

@jstejada so?

I believe the other options listed in #6 are workarounds only.
The key prop must be(miss) used alot already to fix things - for example in #29

Having a repeat option at least eliminates one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants