added form id in querySelector to plugin-survey-multi-choice #3444
+78
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: afe9ebc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jadeddelta
requested changes
Nov 24, 2024
There was a problem hiding this comment.
hey, thanks for the catch @crava2199! just left a bit of a comment down, and also don't forget: for any modifications to plugin code, be sure to run npm run changeset to add a changeset to the PR, just helps us with versioning :)
| @@ -233,7 +235,7 @@ class SurveyMultiChoicePlugin implements JsPsychPlugin<Info> { | |||
| // render | |||
| display_element.innerHTML = html; | |||
|
|
|||
| document.querySelector("form").addEventListener("submit", (event) => { | |||
| document.querySelector(`form#${trial_form_id}`).addEventListener("submit", (event) => { | |||
There was a problem hiding this comment.
i think it would just be more simple to instead directly use querySelector on display_element, which represents the container of the current experiment. just saves the hassle of using interpolation so much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of multiple forms in page,
document.querySelector("form")won't find the proper one.I've added a
trial_form_idto select the form injected from the plugin and add the submit event listener to it.