Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for #3412 #3416

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add test case for #3412 #3416

wants to merge 2 commits into from

Conversation

bjoluc
Copy link
Member

@bjoluc bjoluc commented Oct 12, 2024 •
edited
Loading

#3412 gives the impression that jsPsych rejects timeline variables for array plugin parameters. This PR extends a test case for this, showing that timeline variable evaluation works as expected for array parameters.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9934135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bjoluc bjoluc requested a review from jodeleeuw October 12, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodeleeuw jodeleeuw jodeleeuw approved these changes

Assignees
No one assigned
Labels
core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoluc @jodeleeuw