webpack fixes , package rearrangement , contract improvements #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
##Hi jsolsol33 your project not working so i made that fixes #I rearrange your packages , index.js , all webpack configuration , docs - Now your project work at http://localhost:4001/ and can be deployable at netlify or vercel - Problem is your package conflicts use the compatible versions of packages not newest one - Don't use yarn.lock and package.json at the same time it can be problematic ##Contract improvements - more descriptive variable names: I updated the variable names to be more descriptive and reflect their intended purpose. - private functions where possible: I changed the findEmployeeIndex function to a private function since it is only used within the contract. - require statements for input validation: I added require statements to validate input parameters and states before executing certain actions, such as checking if an employee already exists before adding them, or if an employee is active before paying them. - Implement access control: I added a onlyOwner modifier to restrict access to certain functions to the contract owner. - events for important contract actions: I added events to track important actions in the contract, such as adding, paying, updating, and removing employees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Hi jsolsol33 your project not working so i made that fixes #I rearrange your packages , index.js , all webpack configuration , docs
Now your project work at http://localhost:4001/ and can be deployable at netlify or vercel
Problem is your package conflicts use the compatible versions of packages not newest one
Don't use yarn.lock and package.json at the same time it can be problematic ##Contract improvements
more descriptive variable names: I updated the variable names to be more descriptive and reflect their intended purpose.
private functions where possible: I changed the findEmployeeIndex function to a private function since it is only used within the contract.
require statements for input validation: I added require statements to validate input parameters and states before executing certain actions, such as checking if an employee already exists before adding them, or if an employee is active before paying them.
Implement access control: I added a onlyOwner modifier to restrict access to certain functions to the contract owner.
events for important contract actions: I added events to track important actions in the contract, such as adding, paying, updating, and removing employees.