Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring info divs by wrapping in Additional component for consistency #1110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dhruvtiwari6
Copy link

Related Issue:
This pull request addresses [issue #1070] (if applicable).

This pull request introduces the following changes:

Created a new AdditionalInfoDiv component in StyledMarkdown.tsx.
Wrapped all info divs in applicability-json-schema-fundamentals-part-1.md with the newly created AdditionalInfoDiv component to ensure consistent styling and better maintainability.
These changes aim to improve the structure and styling of the blog post for better readability and easier future updates.

Comparison:
This pull request is comparing changes from the feature branch to the main branch (or other target branch).

Checklist:

Linked to an existing issue: [Issue #1070]
Confirmed all changes are made in the feature branch.
Ensured that modifications are clear and have been tested locally.

Additional Notes:
This change does not introduce any breaking changes and only modifies the structure of the markdown file and its styling component.

@dhruvtiwari6 dhruvtiwari6 requested a review from a team as a code owner November 12, 2024 14:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Nov 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 7c647de

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (26a1127) to head (7c647de).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant