Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sponsors Button Not Working Correctly #1073

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

IyaadDev
Copy link
Contributor

What kind of change does this PR introduce?

  • Makes the entire area of the sponsors' section 'Add your logo here' button clickable
  • Makes the sponsor page open in a new tab

Issue Number:

Summary

  • Fixes 'broken' sponsors button

@IyaadDev IyaadDev requested a review from a team as a code owner October 28, 2024 06:03
@IyaadDev
Copy link
Contributor Author

will fix latest issues with eslint soon

Copy link

github-actions bot commented Oct 28, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview daf4bab

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7666f0d) to head (daf4bab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1073   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IyaadDev
Copy link
Contributor Author

ready to merge 👍

@IyaadDev
Copy link
Contributor Author

IyaadDev commented Nov 6, 2024

@DhairyaMajmudar any people to provide an approving review?

Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When clicking on + Your Logo Here for a Tier, wouldn't it make more sense to redirect to that specific Tier contribution checkout instead of the JSON Schema Contribution page. For example, clicking on Golden Sponsor gets here

@IyaadDev
Copy link
Contributor Author

IyaadDev commented Nov 6, 2024

It would, I'll update the pr

…t it make more sense to redirect to that specific Tier contribution checkout instead of the JSON Schema Contribution page. For example, clicking on Golden Sponsor gets here
@IyaadDev
Copy link
Contributor Author

IyaadDev commented Nov 6, 2024

Done

Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is n8n_logo removed as part of this PR?

@IyaadDev
Copy link
Contributor Author

it was marked as an unused variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Sponsors Button Not Working Correctly
2 participants