Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Bad contrast in the blog's dark theme in info boxes #1070

Open
jaller94 opened this issue Oct 27, 2024 · 5 comments · May be fixed by #1131
Open

🐛 Bug: Bad contrast in the blog's dark theme in info boxes #1070

jaller94 opened this issue Oct 27, 2024 · 5 comments · May be fixed by #1131
Labels
🐛 Bug Indicates that the issue is a bug or defect. good first issue Good for newcomers Hacktoberfest Issues accepeted Hacktoberfest'24 Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue.

Comments

@jaller94
Copy link

Describe the bug

The text in info boxes cannot be read.

Steps To Reproduce

  1. Set your browser to prefer the dark theme.
  2. Go to https://json-schema.org/blog/posts/applicability-json-schema-fundamentals-part-1#putting-everything-together-avoiding-oneof-pitfalls
  3. Look for any of the many info boxes.
  4. The text is not legible.

Expected Behavior

Proper contrast of the font and the background for the dark theme

Screenshots

2024-10-27_13-49_1

The light theme looks ok:

2024-10-27_13-49

Device Information [optional]

- OS: Manjaro
- Browser: Firefox
- version: 131.0.2

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@jaller94 jaller94 added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Oct 27, 2024
@DhairyaMajmudar
Copy link
Member

Thanks for reporting the issue @jaller94

@DhairyaMajmudar DhairyaMajmudar added good first issue Good for newcomers Status: Available No one has claimed responsibility for resolving this issue. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Hacktoberfest Issues accepeted Hacktoberfest'24 and removed Status: Triage This is the initial status for an issue that requires triage. labels Oct 27, 2024
@pavanydg
Copy link

@DhairyaMajmudar pl assign me.

@DhairyaMajmudar
Copy link
Member

Go ahead @pavanydg 🚀

@dhruvtiwari6 dhruvtiwari6 mentioned this issue Nov 12, 2024
Open
@ayushk-1801
Copy link

ayushk-1801 commented Nov 22, 2024 •
edited
Loading

@DhairyaMajmudar please assign me

ayushk-1801 added a commit to ayushk-1801/website that referenced this issue Nov 22, 2024
@ayushk-1801
Fix: Bad contrast in the blog's dark theme in info boxes (json-schema…
b60e91b 
…-org#1070)
@ayushk-1801 ayushk-1801 linked a pull request Nov 22, 2024 that will close this issue
Open
@souvikjs01
Copy link

if the issue is still open, can you assign me @DhairyaMajmudar

@pavanydg pavanydg removed their assignment Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Indicates that the issue is a bug or defect. good first issue Good for newcomers Hacktoberfest Issues accepeted Hacktoberfest'24 Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Bad contrast in the blog's dark theme in info boxes (#1070) ayushk-1801/website
5 participants
@jaller94 @pavanydg @DhairyaMajmudar @ayushk-1801 @souvikjs01