Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Sponsors Button Not Working Correctly #1067

Open
IyaadDev opened this issue Oct 27, 2024 · 3 comments · May be fixed by #1073
Open

🐛 Bug: Sponsors Button Not Working Correctly #1067

IyaadDev opened this issue Oct 27, 2024 · 3 comments · May be fixed by #1073
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. good first issue Good for newcomers Hacktoberfest Issues accepeted Hacktoberfest'24 Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@IyaadDev
Copy link
Contributor

IyaadDev commented Oct 27, 2024

Describe the bug

While the "Add your brand here" technically works, most users would perceive this as not working / broken, as only the text saying "Your logo here" has a href referencing the link, meaning the rest of the button, inclusive of the "+" icon does not function, providing a misleading idea that it is a broken link

Steps To Reproduce

  1. Navigate to https://json-schema.org/ (Note: adding #sponsors only works some of the time for some reason, directly going to https://json-schema.org/#sponsors does not open sponsors instantly)
  2. Scroll down to "Sponsors"
  3. The buttons mentioned in the bug description are visible

Expected Behavior

Typically, users should expect that the entire button be responsive, perhaps also adding a target=blank or _blank to open in a new tab (not necessary, just personal opinion), but most of the button is unresponsive and does not go to the contribute url

Screenshots

Screencast.from.2024-10-27.13-50-59.mp4

Device Information [optional]

- OS: Ubuntu 22.04
- Browser: edge
- version: 22

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@IyaadDev IyaadDev added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Oct 27, 2024
@DhairyaMajmudar
Copy link
Member

Good find @IyaadDev the whole button should be acting as a redirecting link

@DhairyaMajmudar DhairyaMajmudar added good first issue Good for newcomers Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Hacktoberfest Issues accepeted Hacktoberfest'24 and removed Status: Triage This is the initial status for an issue that requires triage. labels Oct 27, 2024
@IyaadDev
Copy link
Contributor Author

Thanks, @DhairyaMajmudar, working on this issue at the moment

@IyaadDev IyaadDev linked a pull request Oct 28, 2024 that will close this issue
@IyaadDev
Copy link
Contributor Author

ready to merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. good first issue Good for newcomers Hacktoberfest Issues accepeted Hacktoberfest'24 Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants