Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue collector adding graphql support #478

Merged
merged 35 commits into from
Sep 20, 2023
Merged

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Sep 11, 2023

This PR provide support to discussions in the Github action responsible of adding agenda items. We need to use the graphql API because the rest API does not support discussions.

This does not require ADR: No

Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Haven't checked API usage, though.

Left a comment.

.github/workflows/ocwm-issue-collector.yml Outdated Show resolved Hide resolved
Remove unnecessary comment
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API usage looks good.

@benjagm benjagm merged commit ba4af50 into json-schema-org:main Sep 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants