Add informative parameters to 'RateLimited' Exception #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…order to allow proper differentiation and documentation in case of multiple rate limit decorators on the same django view.
|
@jsocol Any feedback? |
Andrew-Chen-Wang
suggested changes
May 6, 2021
| @@ -20,7 +20,7 @@ def _wrapped(request, *args, **kw): | |||
| increment=True) | |||
| request.limited = ratelimited or old_limited | |||
| if ratelimited and block: | |||
| raise Ratelimited() | |||
| raise Ratelimited(group=group, key=key, rate=rate) | |||
There was a problem hiding this comment.
Why stop there? How about allow users to give a message for Ratelimit (helpful if you've got a middleware that can't differentiate views).
|
Hey, I had similar idea but I would say than instead of passing individual parameters, why not pass what get_usage returns? This way people might use the additional information like Let me know, I can prepare a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jsocol in order to allow proper differentiation and documentation in case of multiple rate limit decorators on a single Django view, i have added 'key', 'group' and 'rate' details to 'RateLimited' Exception, WDYT?
Thanks :)