Update @npmcli/arborist
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the dependency `@npmcli/arborist` from v6 to v7 in order to
transitively upgrade or remove dependencies. For example, the dependency
`@npmcli/move-file` is deprecated and dropped by `@npmcli/arborist` v7.
Similarly, the dependency `glob` is deprecated at v7 and v8 (both were
previously in the dependency tree) and has been upgrade to v10.
The exact version I picked is the first v7 release that occurred after
the release of the release of v6.5.0, which hopefully means any feature
of v6.5.0 used by this project is also present in the selected minimum
v7 release.
The effect can be seen from within this repository as follows, before
(on `main`):
$ npm install --omit dev
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: This package is no longer supported.
added 268 packages, and audited 269 packages in 4s
[...]
after (this commit):
$ npm install --omit dev
added 187 packages, and audited 188 packages in 3s
[...]
|
There's no longer a separate changelog for Arborist. It's been moved into the npm CLI monorepo, in a workspace subdirectory. wget https://registry.npmjs.org/@npmcli/arborist/-/arborist-6.5.0.tgz
unp arborist-6.5.0.tgz
mv package 6.5.0
wget https://registry.npmjs.org/@npmcli/arborist/-/arborist-7.2.1.tgz
unp arborist-7.2.1.tgz
mv package 7.2.1
diff -ru 6.5.0 7.2.1Output:
diff -ur 6.5.0/lib/query-selector-all.js 7.2.1/lib/query-selector-all.js
--- 6.5.0/lib/query-selector-all.js 1985-10-26 01:15:00.000000000 -0700
+++ 7.2.1/lib/query-selector-all.js 1985-10-26 01:15:00.000000000 -0700
@@ -695,7 +695,11 @@
// the compare nodes array
const hasParent = (node, compareNodes) => {
// All it takes is one so we loop and return on the first hit
- for (const compareNode of compareNodes) {
+ for (let compareNode of compareNodes) {
+ if (compareNode.isLink) {
+ compareNode = compareNode.target
+ }
+
// follows logical parent for link anscestors
if (node.isTop && (node.resolveParent === compareNode)) {
return true
diff -ur 6.5.0/package.json 7.2.1/package.json
--- 6.5.0/package.json 1985-10-26 01:15:00.000000000 -0700
+++ 7.2.1/package.json 1985-10-26 01:15:00.000000000 -0700
@@ -1,39 +1,39 @@
{
"name": "@npmcli/arborist",
- "version": "6.5.0",
+ "version": "7.2.1",
"description": "Manage node_modules trees",
"dependencies": {
"@isaacs/string-locale-compare": "^1.1.0",
"@npmcli/fs": "^3.1.0",
"@npmcli/installed-package-contents": "^2.0.2",
"@npmcli/map-workspaces": "^3.0.2",
- "@npmcli/metavuln-calculator": "^5.0.0",
+ "@npmcli/metavuln-calculator": "^7.0.0",
"@npmcli/name-from-folder": "^2.0.0",
"@npmcli/node-gyp": "^3.0.0",
- "@npmcli/package-json": "^4.0.0",
- "@npmcli/query": "^3.0.0",
- "@npmcli/run-script": "^6.0.0",
+ "@npmcli/package-json": "^5.0.0",
+ "@npmcli/query": "^3.0.1",
+ "@npmcli/run-script": "^7.0.2",
"bin-links": "^4.0.1",
- "cacache": "^17.0.4",
+ "cacache": "^18.0.0",
"common-ancestor-path": "^1.0.1",
- "hosted-git-info": "^6.1.1",
+ "hosted-git-info": "^7.0.1",
"json-parse-even-better-errors": "^3.0.0",
"json-stringify-nice": "^1.1.4",
"minimatch": "^9.0.0",
"nopt": "^7.0.0",
"npm-install-checks": "^6.2.0",
- "npm-package-arg": "^10.1.0",
- "npm-pick-manifest": "^8.0.1",
- "npm-registry-fetch": "^14.0.3",
+ "npm-package-arg": "^11.0.1",
+ "npm-pick-manifest": "^9.0.0",
+ "npm-registry-fetch": "^16.0.0",
"npmlog": "^7.0.1",
- "pacote": "^15.0.8",
+ "pacote": "^17.0.4",
"parse-conflict-json": "^3.0.0",
"proc-log": "^3.0.0",
"promise-all-reject-late": "^1.0.0",
"promise-call-limit": "^1.0.2",
"read-package-json-fast": "^3.0.2",
"semver": "^7.3.7",
- "ssri": "^10.0.1",
+ "ssri": "^10.0.5",
"treeverse": "^3.0.0",
"walk-up-path": "^3.0.1"
},
@@ -42,8 +42,8 @@
"@npmcli/template-oss": "4.19.0",
"benchmark": "^2.1.4",
"minify-registry-metadata": "^3.0.0",
- "nock": "^13.3.0",
- "tap": "^16.3.4",
+ "nock": "^13.3.3",
+ "tap": "^16.3.8",
"tar-stream": "^3.0.0",
"tcompare": "^5.0.6"
},
@@ -79,7 +79,6 @@
"test-env": [
"LC_ALL=sk"
],
- "color": 1,
"timeout": "360",
"nyc-arg": [
"--exclude",
@@ -87,7 +86,7 @@
]
},
"engines": {
- "node": "^14.17.0 || ^16.13.0 || >=18.0.0"
+ "node": "^16.14.0 || >=18.0.0"
},
"templateOSS": {
"//@npmcli/template-oss": "This file is partially managed by @npmcli/template-oss. Edits may be overwritten.",@ljharb any reason not to update |
|
That's fine, but to minimize future majors, it's probably best to do something like |
|
I'm sorry but I'm slightly confused. The
meaning that Arborist's is a superset of Licensee (because - "node": "^18.12 || ^20.9 || >= 22.7"
+ "node": ">=18.12"that wouldn't be a breaking change - supporting more Node.js versions won't break any existing users. |
|
ping @kemitchell - seems @ljharb is okay with the changes as is |
|
There being no |
|
I would say so, @kemitchell |
kemitchell
approved these changes
Oct 5, 2024
|
v11.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of #90 following the engines update in #96. Now, the upgrade of
@npmcli/arboristfrom v6 to v7 is no longer a breaking change for licensee. I had to recreate the PR because I had deleted my fork of this project.Update the dependency
@npmcli/arboristfrom v6 to v7 in order to transitively upgrade or remove deprecated dependencies. For example, the dependency@npmcli/move-fileis deprecated and dropped by@npmcli/arboristv7. Similarly, the dependencyglobis deprecated at v7 and v8 (both were previously in the dependency tree) and has been upgrade to v10.The exact version I picked is the first v7 release that occurred after the release of the release of v6.5.0, which hopefully means any feature of v6.5.0 used by this project is also present in the selected minimum v7 release.
The effect can be seen from within this repository as follows, before (on
mainat d746a5b):after (this PR):