Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fetch] jsk_fetch_robot/fetcheus/fetch-interface.l :angle-vector, :angle-vector-sequence supports old API #795

Merged
merged 7 commits into from
Jun 28, 2017

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jun 22, 2017

this is rewrited version of #791
related to jsk-ros-pkg/jsk_pr2eus#302, some people like old :angle-vector API, like

:angle-vector av tm :use-torso t

currently we have to use

:angle-vector av tm nil 0 :use-torso t

@k-okada k-okada requested a review from knorth55 June 22, 2017 12:52
@k-okada k-okada changed the title Fetch angle vector sequence Fetch angle vector sequence supports old API Jun 22, 2017
@knorth55
Copy link
Member

knorth55 commented Jun 22, 2017

@k-okada This is just a question, but start-offset-time in :angle-vector-motion-plan is equal to start-time in angle-vector?

@k-okada
Copy link
Member Author

k-okada commented Jun 24, 2017

@knorth55 , I think so, originally we have trouble if we send trajectory startring from current time, and receiver (robot controller) receved that trajectry as a past time (assuming it takes time during data transfer), the controller did not execute the time, that's why we added start-time, may we no longer need that one, for example start-jsk/rtmros_common#1013

:angle-vector

   (let ((cacts (gethash ctype controller-table)))
     (mapcar
      #'(lambda (action param)
          (send self :send-ros-controller
                action (cdr (assoc :joint-names param)) ;; action server and joint-names
                start-time  ;; start time
                (list
                 (list av                                     ;; positions
                       (instantiate float-vector (length av)) ;; velocities
                       (/ tm 1000.0)))))                      ;; duration
      cacts (send self ctype)))

:angle-vector-motion-plan

                 (when time-from-start
                   (setq points
                         (let (tmp-points)
                           (dolist (pt points)
                             (send pt :time_from_start
                                   (ros::time
                                     (+ time-from-start
                                        start-offset-time
                                        (send (send pt :time_from_start)
                                              :to-sec))))
                             (setq tmp-points
                                   (append tmp-points (list pt))))
                           tmp-points)))

@k-okada k-okada changed the title Fetch angle vector sequence supports old API [Fetch] jsk_fetch_robot/fetcheus/fetch-interface.l :angle-vector, :angle-vector-sequence supports old API Jun 25, 2017
@knorth55
Copy link
Member

@k-okada I made a PR k-okada#2

pass start-time to start-offset-time and support :start-time key
@knorth55
Copy link
Member

@k-okada can you merge this?

@k-okada k-okada merged commit 9d4ed32 into jsk-ros-pkg:master Jun 28, 2017
@wkentaro wkentaro added this to the 1.0.10 milestone Jul 11, 2017
@k-okada k-okada deleted the fetch-angle-vector-sequence branch June 22, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants