Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_robot_startup] add viso2_ros to package.xml #1335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Naoki-Hiraoka
Copy link
Contributor

jsk_robot_startup depends on viso2_ros, but viso2_ros does not exist in package.xml of jsk_robot_startup.

<node pkg="viso2_ros" type="stereo_odometer" name="viso_node"

This caused me an error when I set up real HRP2JSK and HRP2JSKNT environment.
I added viso2_ros to run_depend in package.xml.

@knorth55
Copy link
Member

knorth55 commented May 10, 2021

LGTM
but viso2_ros is released in kinetic, melodic and noetic?
I cannot find this package in rosdistro for kinetic, melodic and noetic.

@Naoki-Hiraoka
Copy link
Contributor Author

viso2_ros is not released.
We have to compile it from source. (I'm going to write viso2_ros to .rosinstall for HRP2)
This PR enables to compile viso2_ros automatically when we compile jsk_robot_startup.

@knorth55
Copy link
Member

you should open a release request issue in viso2 for kinetic, melodic and noetic.

@Naoki-Hiraoka
Copy link
Contributor Author

Naoki-Hiraoka commented May 10, 2021

melodicについて既にissueが立っていたので,+1してきました.

srv/viso2#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants