Fix bug if missing linked item

jrmi · May 13, 2024 · d6af915 · d6af915
1 parent 2c97087
commit d6af915
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/src/lib/board/Items/useItemActions.js b/src/lib/board/Items/useItemActions.js
@@ -292,10 +292,9 @@ const useItemActions = () => {
       });
 
       insertItems(itemsWithPosition, beforeId);
-
-      updateItemExtent();
+      placeItems(itemsToInsert.map((item) => item.id));
     },
-    [getCenter, insertItems, updateItemExtent]
+    [getCenter, insertItems, placeItems]
   );
 
   const pushItem = React.useCallback(

diff --git a/src/lib/utils.js b/src/lib/utils.js
@@ -212,14 +212,19 @@ const getLinkedItemsRecursive = (itemMap, itemIds, alreadyMet = null) => {
         return [];
       } else {
         alreadyMet.add(itemId);
-        return [
-          itemId,
-          ...getLinkedItemsRecursive(
-            itemMap,
-            itemMap[itemId].linkedItems,
-            alreadyMet
-          ),
-        ];
+        if (itemMap[itemId]) {
+          // If the item has been removed but not from linked list
+          return [
+            itemId,
+            ...getLinkedItemsRecursive(
+              itemMap,
+              itemMap[itemId].linkedItems,
+              alreadyMet
+            ),
+          ];
+        } else {
+          return [];
+        }
       }
     })
     .flat();