Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of SurfaceTransformTask in TrajectoryTask #44

Open
stephane-caron opened this issue Apr 24, 2018 · 0 comments
Open

Consistency of SurfaceTransformTask in TrajectoryTask #44

stephane-caron opened this issue Apr 24, 2018 · 0 comments

Comments

@stephane-caron
Copy link
Contributor

The error vector in TrajectoryTask::update is computed as:

	error_.noalias() = gainPos_*err;
	error_.noalias() += gainVel_*(refVel_ - speed);
	error_.noalias() += refAccel_;

When the underlying task is a SurfaceTransformTask, speed should be the time-derivative of err.

  • Note that this is not consistent with other tasks such as the SurfaceOrientationTask where speed is the velocity of the body itself, not of the error vector in the body frame.
  • Then that means refVel should be a reference for the time-derivative of the tracking error, which does not make sense.

This makes a difference but we should not see it much in practice because the speed of a SurfaceTransformTask is mostly the surface frame's body velocity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant