Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken auto_tagger example #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnhampton
Copy link
Contributor

In auto_tagger.rake stage.revision returns both the sha and the named
ref. This causes git update-ref to fail. Passing only the sha portion of
stage.revision to create_and_push resolves the issue.

Here is the error that I received:

cd "/Users/john/Projects/tan-expedite" && git fetch origin refs/tags/*:refs/tags/*
cd "/Users/john/Projects/tan-expedite" && git update-ref refs/tags/staging/20130309015938 18f8e4c89122ed087884a69dc8e9bfa8085eef77 tags/ci/20130309013517
error: unable to resolve reference refs/tags/staging/20130309015938: No such file or directory
fatal: Cannot lock the ref 'refs/tags/staging/20130309015938'.
rake aborted!
AutoTagger::Git::Repo::GitCommandFailedError
/Users/john/Projects/tan-expedite/lib/tasks/heroku.rake:6:in `create_and_push'
/Users/john/Projects/tan-expedite/lib/tasks/heroku.rake:18:in `block (2 levels) in <top (required)>'
/Users/john/Projects/tan-expedite/lib/tasks/heroku.rake:17:in `block in <top (required)>'
Tasks: TOP => deploy => heroku:deploy
(See full trace by running task with --trace)

In auto_tagger.rake stage.revision returns both the sha and the named
ref. This causes git update-ref to fail. Passing only the sha portion of
stage.revision to create_and_push resolves the issue.
@rahearn
Copy link
Contributor

rahearn commented Mar 11, 2013

Pulling in @kmayer as he wrote more of this code.

Instead of this fix, should stage.revision just return the SHA from git_revision instead of passing that to git_named_rev?

@kmayer
Copy link
Contributor

kmayer commented Mar 11, 2013

I'm on vacation this week, so it might be a week before I can look into it. Not a clue. If the method name doesn't provide enuf guidance, then it might be worth a look.

Sent from my iPhone ~ 808.722.6142

On Mar 10, 2013, at 6:07 PM, Ryan Ahearn [email protected] wrote:

Pulling in @kmayer as he wrote more of this code.

Instead of this fix, should stage.revision just return the SHA from git_revision instead of passing that to git_named_rev?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants