-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Swift Argument Parser versions from 1.2.1 to 2.0.0 #799
Conversation
While I'm doing this — would you be willing to consider changing this dependency from |
Yes, let's do that but revert back to 1.2 so that if other packages are depending on 1.2.x this change doesn't break them. |
Don't worry about the Bazel test failures, there's been some changes to Bazel that I should adjust for. |
No problems, I'll do it now. Did you want me to do the same for SWXMLHash? |
Yes please! 🙏 |
…to SAP 1.2.1 This is preferable to raising the required version.
Done in 91d9cd7. I'll do the same for SwiftLint once there's a tagged release of SourceKitten with these changes in it. Thanks, JP! |
Can this be merged? Together with a new release, SwiftLint could use 1.3.0 of Swift Argument Parser. |
Hello @SimplyDanny, I wish to have this update available as I cannot use both OpenAPI and SwiftLint. |
I need this as well 🙏🏻 |
Ill merge and look into the CI failures async. |
Thank you very much 🙏🏻 Hopefully you have time to push a new release as well, containing this change. |
0.35.0 was pushed with these changes: https://github.com/jpsim/SourceKitten/releases/tag/0.35.0 |
Continued in realm/SwiftLint#5562 |
This lower version number is preventing packages from using SwiftLint and the Swift OpenAPI Generator in the same package.