Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate jlabel-question crate #8

Merged
merged 10 commits into from
Jan 17, 2024
Merged

separate jlabel-question crate #8

merged 10 commits into from
Jan 17, 2024

Conversation

cm-ayf
Copy link
Contributor

@cm-ayf cm-ayf commented Jan 17, 2024

questionを別crateに分離したい

@cm-ayf cm-ayf self-assigned this Jan 17, 2024
@cm-ayf cm-ayf force-pushed the separate-question branch from 26221e7 to e1f5e67 Compare January 17, 2024 03:23
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2d32810) 85.03% compared to head (3ec95e6) 90.86%.

Files Patch % Lines
crates/jlabel-question/src/lib.rs 97.95% 1 Missing ⚠️
crates/jlabel-question/src/position.rs 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   85.03%   90.86%   +5.83%     
==========================================
  Files           5        6       +1     
  Lines         628      854     +226     
==========================================
+ Hits          534      776     +242     
+ Misses         94       78      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cm-ayf cm-ayf changed the title move test functionarity to AllQuestion separate jlabel-question crate Jan 17, 2024
@cm-ayf cm-ayf marked this pull request as ready for review January 17, 2024 04:04
@cm-ayf cm-ayf requested a review from phenylshima as a code owner January 17, 2024 04:04
@cm-ayf
Copy link
Contributor Author

cm-ayf commented Jan 17, 2024

moveだけではない変更点

  • src/question/mod.rs -> crates/jlabel-question/src/lib.rs
    • 大幅に変更
    • テストが分離
    • AllQuestion::testQuestion::test追加
  • src/question/position.rs -> crates/jlabel-question/src/position.rs
    • Position::get追加
  • src/question/mod.rs -> crates/jlabel-question/src/test.rs
    • splitter若干増加
    • parse_question_err追加
    • all_querynoneszerosの両方をtestするように変更
  • src/fullcontext_label.rs -> crates/jlabel/src/fullcontext_label.rs
    • Label::satisfiesAllQuestion::test配下に移動

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@femshima もフルコンテキストラベルにフルではないバージョンがあるのかと言われるとわからないのですが,labelで良かったような気もしつつ…

@cm-ayf cm-ayf merged commit abe7fed into main Jan 17, 2024
5 checks passed
@cm-ayf cm-ayf deleted the separate-question branch January 17, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants