Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fallback #15

Merged
merged 10 commits into from
Jan 24, 2024
Merged

Implement Fallback #15

merged 10 commits into from
Jan 24, 2024

Conversation

phenylshima
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e760e91) 91.76% compared to head (a81a776) 91.43%.

Files Patch % Lines
crates/jlabel-question/src/regex.rs 77.27% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   91.76%   91.43%   -0.33%     
==========================================
  Files           7        8       +1     
  Lines         959      981      +22     
==========================================
+ Hits          880      897      +17     
- Misses         79       84       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phenylshima phenylshima marked this pull request as ready for review January 22, 2024 08:41
@phenylshima
Copy link
Member Author

  • AllPositionとは独立にRegexMatcherを提供
  • 一方でtraitにするのは正しい気がする
  • RegexMatcherの有無はfeatureで制御

@phenylshima phenylshima marked this pull request as draft January 23, 2024 12:35
@phenylshima phenylshima marked this pull request as ready for review January 24, 2024 05:31
@phenylshima phenylshima requested a review from cm-ayf January 24, 2024 05:36
Copy link
Contributor

@cm-ayf cm-ayf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod名とfeature名がmismatchなので,regexかfallbackかに統一すべきな気がします.

crates/jlabel-question/src/lib.rs Show resolved Hide resolved
@phenylshima phenylshima merged commit 83e4303 into main Jan 24, 2024
3 of 5 checks passed
@phenylshima phenylshima deleted the fallback branch January 24, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants