Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Read File Already Closed #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ex-preman
Copy link

  • Fix read file already closed
  • Move to dep from go mod
  • Floating coverage precision and validation

Yusuf Septiananda added 4 commits May 19, 2021 00:20
- Fix read file already closed
- Move go dep to go mod
- Increase floating coverage precision
@jpoles1
Copy link
Owner

jpoles1 commented Aug 7, 2021

Hi @ex-preman, sorry for the delay I've been very backlogged with work. Thanks for your contribution, however I cannot merge this PR at this time, as it has too many different changes all included at once. Can you please separate each major change into its own PR, and then I will be able to review them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants