Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback execution when request fails #6

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

dafortune
Copy link

Call end callback when there is an error

Fixes #5

jpodwys pushed a commit that referenced this pull request Sep 29, 2015
Fix callback execution when request fails
@jpodwys jpodwys merged commit 471d333 into jpodwys:master Sep 29, 2015
@jpodwys
Copy link
Owner

jpodwys commented Sep 29, 2015

Merged and published in NPM release 1.0.3. Thanks for the input!

@fraczak
Copy link

fraczak commented Feb 25, 2016

I experience the problem (in a browser via browserify) on version 1.7.2 :(

@jpodwys
Copy link
Owner

jpodwys commented Feb 25, 2016

Superagent made some internally breaking changes in 1.7.0 and later. Please see #32 for more information on what's being done about it. If you don't need anything in 1.7.0 or later, please move to 1.6.1 until a resolution is reached. If you still encounter the error while using 1.6.1, please let me know.

I referenced this page from the linked issue.

@jpodwys
Copy link
Owner

jpodwys commented Feb 26, 2016

@fraczak Can you please provide more information? Were you on an older version of superagent and everything was working well until you upgraded, or did you just come across this the first time you tried to use superagent-cache?

@jpodwys
Copy link
Owner

jpodwys commented Feb 26, 2016

@fraczak If you can, I'd appreciate a code demo. I'm unable to reproduce this error, even on 1.7.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants