-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.x Discussion #25
Comments
Honouring server http caching headers ? |
Add statistics of cache hit, missed, expired... to the API |
@jacobbubu that's a great idea! Are you wanting it to do pretty much what the link below shows or a lot more than this, or am I way off? |
Well, more like this one https://github.com/rjrodger/seneca-vcache/blob/master/vcache.js. |
Thanks for the link! Because In fact, if you're using the Similarly, if you're using However, if you're using the bundled cache instance ( |
Explanation
This is intended to be a discussion area for breaking changes that anyone thinks should be made to superagent-cache. Please also present ideas that are not breaking changes that, for whatever reason, don't make sense in
1.x
. I will take these suggestions into consideration when thinking about coding version2.0.0
of superagent-cache. No coding has begun for2.0.0
, so all ideas are welcome. As the number of compelling ideas presented increases, the likelihood that a2.0.0
release will be made increases. If no or very few ideas are presented, I'll just stick with1.x
.Nothing posted here is for sure--this is discussion only. Please comment on existing ideas to say whether you agree.
Breaking Changes:
.pruneParams
to.pruneQuery
and.pruneOptions
to.pruneHeader
or something similar.._end()
rather than when calling.end()
. This will prevent the odd redirects behavior I currently have to work around.Non-Breaking Changes:
2.x
without more reliable tests and better test coverage, including tests that run in browsers.Other considerations
2.0.0
, which I don't like.The text was updated successfully, but these errors were encountered: