Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify theme next storybook toolbar #3393

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Simplify theme next storybook toolbar #3393

merged 6 commits into from
Jun 20, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented May 9, 2024 •
edited
Loading

We're going to introduce 3 different toggles for theme next, which can be too wide for small screens for ease of use. Add as a single list.

  • For some reason, prod build this doesn't show up

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:49am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8959eac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@origami-z origami-z marked this pull request as draft May 9, 2024 20:50
@joshwooding
Copy link
Contributor

@origami-z is this still something being looked at?

@origami-z origami-z force-pushed the theme-next-sb-toolbar branch from cffff0c to 6d35824 Compare June 12, 2024 10:35
@origami-z
Copy link
Contributor Author

@origami-z is this still something being looked at?

Worked now, not sure whether this is actually better lol

@origami-z origami-z marked this pull request as ready for review June 12, 2024 12:09
@origami-z origami-z force-pushed the theme-next-sb-toolbar branch from 6d35824 to 8959eac Compare June 20, 2024 08:43
@jpmorganchase jpmorganchase deleted a comment from github-actions bot Jun 20, 2024
@joshwooding joshwooding changed the title Simplifies theme next storybook toolbar Simplify theme next storybook toolbar Jun 20, 2024
@joshwooding joshwooding merged commit 0e3f091 into main Jun 20, 2024
15 checks passed
@joshwooding joshwooding deleted the theme-next-sb-toolbar branch June 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjungyeh yunjungyeh yunjungyeh approved these changes

@lilyvc lilyvc lilyvc approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@origami-z @joshwooding @lilyvc @yunjungyeh