Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server side CB example #3382

Merged
merged 2 commits into from
May 10, 2024
Merged

Update server side CB example #3382

merged 2 commits into from
May 10, 2024

Conversation

joshwooding
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 1f37df7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:57pm

Copy link
Contributor

github-actions bot commented May 8, 2024

Storybook Preview Link https://24ddf8e6.saltdesignsystem-storybook.pages.dev

Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better than before.

Not so sure whether showing empty list is the best solution, it feels something is rendered (arrow flipped, list shadow, some border) and also not.

@joshwooding
Copy link
Contributor Author

It's better than before.

Not so sure whether showing empty list is the best solution, it feels something is rendered (arrow flipped, list shadow, some border) and also not.

I think that's more a bug in CB, I need to talk to @bhoppers2008 but I'm thinking CB shouldn't be in an open state when no items are in the list

@joshwooding joshwooding merged commit 6b3c13e into main May 10, 2024
15 checks passed
@joshwooding joshwooding deleted the server-side-data-db-updates branch May 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants