Allow sharp country symbols to be supported by the country symbol CSS file #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JoanaMMoreira
commented
May 8, 2024
•
JoanaMMoreira
commented
- Add script to generate sharp symbol's css (same as for rounded symbols)
- Update country symbol html template
- Add QA story for sharp country symbols
- Update site examples and docs at https://saltdesignsystem-git-sharp-country-symbol-css-fed-team.vercel.app/salt/components/country-symbol/examples#css-background-image
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e8eaef0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Storybook Preview Link https://0f69a37e.saltdesignsystem-storybook.pages.dev |
Fercas123
reviewed
May 10, 2024
1 task
Fercas123
approved these changes
May 10, 2024
Co-authored-by: Fernanda Castillo <[email protected]>
joshwooding
force-pushed
the
sharp-country-symbol-css
branch
from
52be3f9 to
e8eaef0
Compare
joshwooding
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.