Review feedback

jpmorganchase · May 14, 2024 · ac3a8fb · ac3a8fb
1 parent 340941a
commit ac3a8fb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/.changeset/sour-experts-rest.md b/.changeset/sour-experts-rest.md
@@ -4,12 +4,13 @@
 
 Added new tokens
 
-| Tier | Token | Value |
-| Foundation | `--salt-typography-fontFamily-openSans` | "Open Sans" |
-| Foundation | `--salt-typography-fontFamily-ptMono` | "PT Mono" |
-| Palette | `--salt-palette-text-fontFamily` | `--salt-typography-fontFamily-openSans` |
-| Palette | `--salt-palette-text-fontFamily-heading` | `--salt-typography-fontFamily-openSans` |
-| Palette | `--salt-palette-text-fontFamily-code` | `--salt-typography-fontFamily-ptMono` |
+| Tier       | Token                                    | Value                                   |
+| ---------- | ---------------------------------------- | --------------------------------------- |
+| Foundation | `--salt-typography-fontFamily-openSans`  | "Open Sans"                             |
+| Foundation | `--salt-typography-fontFamily-ptMono`    | "PT Mono"                               |
+| Palette    | `--salt-palette-text-fontFamily`         | `--salt-typography-fontFamily-openSans` |
+| Palette    | `--salt-palette-text-fontFamily-heading` | `--salt-typography-fontFamily-openSans` |
+| Palette    | `--salt-palette-text-fontFamily-code`    | `--salt-typography-fontFamily-ptMono`   |
 
 Updated existing token value mapping to use new tokens
 

diff --git a/.storybook/styles.css b/.storybook/styles.css
@@ -1,5 +1,5 @@
 .salt-theme .sbdocs {
-  font-family: var(--salt-palette-text-fontFamily);
+  font-family: var(--salt-text-fontFamily);
   font-size: var(--salt-text-fontSize);
   letter-spacing: var(--salt-text-letterSpacing);
   line-height: var(--salt-text-lineHeight);
@@ -41,7 +41,7 @@
   color: var(--salt-color-gray-900);
   font-size: var(--salt-text-fontSize);
   line-height: var(--salt-text-lineHeight);
-  font-family: var(--salt-palette-text-fontFamily-code);
+  font-family: var(--salt-text-code-fontFamily);
   font-size: var(--salt-text-fontSize);
   letter-spacing: var(--salt-text-letterSpacing);
   line-height: var(--salt-text-lineHeight);

diff --git a/packages/lab/stories/skip-link/skip-link.stories.css b/packages/lab/stories/skip-link/skip-link.stories.css
@@ -4,6 +4,6 @@
 
 .goalsList {
   font-size: var(--salt-text-fontSize);
-  font-family: var(--salt-palette-text-fontFamily);
+  font-family: var(--salt-text-fontFamily);
   line-height: var(--salt-text-lineHeight);
 }
diff --git a/tooling/css-variable-docgen-components/src/CharacteristicUsage.css b/tooling/css-variable-docgen-components/src/CharacteristicUsage.css
@@ -1,5 +1,5 @@
 .characteristicTokenDoc {
-  font-family: var(--salt-palette-text-fontFamily-code);
+  font-family: var(--salt-text-fontFamily-code);
   height: var(--salt-size-base);
   margin: var(--salt-size-unit);
 }