fix bug: representation for name of file and match #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
bug
sebinside
requested changes
Nov 14, 2022
core/src/main/java/de/jplag/reporting/jsonfactory/ComparisonReportWriter.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
cyfml
force-pushed
the
fix/issue-710-1
branch
from
8d1c3a2 to
6a5ce87
Compare
tsaglam
changed the title
tsaglam
requested changes
Nov 19, 2022
There was a problem hiding this comment.
A few issues regarding code quality. Also, Sonar found one code smell.
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/DirectoryManager.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/reportobject/ReportObjectFactoryTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/DirectoryManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/DirectoryManager.java
Outdated
Show resolved
Hide resolved
sebinside
approved these changes
Nov 25, 2022
sebinside
approved these changes
Nov 25, 2022
tsaglam
requested changes
Nov 25, 2022
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/reportobject/ReportObjectFactoryTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/DirectoryManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/jplag/reporting/jsonfactory/ComparisonReportWriter.java
Outdated
Show resolved
Hide resolved
59 tasks
tsaglam
requested changes
Nov 28, 2022
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
tsaglam
requested changes
Nov 29, 2022
core/src/test/java/de/jplag/reporting/jsonfactory/DirectoryManagerTest.java
Outdated
Show resolved
Hide resolved
…agerTest.java Co-authored-by: Timur Sağlam <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
tsaglam
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the submissions's folder structure and json file of comparison(i.e. A-B.json) in zip file. Now match and file name are represented with their full path (include root directory). And the problem in #658 is also solved. And when file name is too long, it only shows part of the full path(i.e. ..subfolder/subsubfolder/algorithm.java).