-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework report viewer error handling #1362
Conversation
…r-handling # Conflicts: # report-viewer/src/views/InformationView.vue
Funny test case, that completely crashed the report viewer: If you drag a completely unrelated zip (i tested this with a zip containing the JPlag font, don't ask why 😅) this leads to a frozen viewer with the message Edit: Of course, this does not happen in this PR, but in previous versions. Should have mentioned that. |
Missing error: Arbitrary router errors, e.g., manually navigating to |
Opening up the report viewer greets me with a red |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions! I only have three minor comments, please see above
[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Should be implemented now
This, was due to the FileUploadView#L40 having an
I could not reproduce it with a zip. Although I could with other file types. It should be fixed now (Errors not shown due to same comparison error as above and not resetting the loadingFiles varriable). Can you confirm that again with you zip? @sebinside |
This PR reworks the error handling of the report viewer.
Rewrite Error View:
Error handling:
Where we catch errors: