Skip to content

Commit

Permalink
convert circleci workflows to github actions (facebook#1301)
Browse files Browse the repository at this point in the history
Summary:
<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The two fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/hermes) and create your branch from `main`.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Ensure it builds and the test suite passes. [tips](https://github.com/facebook/hermes/blob/HEAD/doc/BuildingAndRunning.md)
  4. Format your code with `.../hermes/utils/format.sh`
  5. If you haven't already, complete the CLA.
-->

This pull request converts the CircleCI workflows to GitHub actions workflows.

### Errors
The `linux` job fails with the following unit test failure...

<details>
<summary>Error</summary>

```
-- Testing: 1976 tests, 4 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80..
FAIL: Hermes-Unit :: VMRuntime/./HermesVMRuntimeTests/GCReturnUnusedMemoryTest.CollectReturnsFreeMemory (1808 of 1976)
******************** TEST 'Hermes-Unit :: VMRuntime/./HermesVMRuntimeTests/GCReturnUnusedMemoryTest.CollectReturnsFreeMemory' FAILED ********************
Note: Google Test filter = GCReturnUnusedMemoryTest.CollectReturnsFreeMemory
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from GCReturnUnusedMemoryTest
[ RUN      ] GCReturnUnusedMemoryTest.CollectReturnsFreeMemory
/home/runner/work/hermes/hermes/hermes/unittests/VMRuntime/GCReturnUnusedMemoryTest.cpp:68: Failure
Expected: (*before) < (*touched), actual: 3009 vs 3009
[  FAILED  ] GCReturnUnusedMemoryTest.CollectReturnsFreeMemory (5 ms)
[----------] 1 test from GCReturnUnusedMemoryTest (5 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (5 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GCReturnUnusedMemoryTest.CollectReturnsFreeMemory

 1 FAILED TEST

********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
Testing Time: 13.21s
********************
Failing Tests (1):
    Hermes-Unit :: VMRuntime/./HermesVMRuntimeTests/GCReturnUnusedMemoryTest.CollectReturnsFreeMemory

  Expected Passes    : 1848
  Unsupported Tests  : 127
  Unexpected Failures: 1
  ```

  </details>

Pull Request resolved: facebook#1301

Test Plan:
The workflows was tested in my fork. [Here is the latest workflow run in my fork](https://github.com/robandpdx-org/hermes/actions/runs/7832320547).

https://fburl.com/workplace/f6mz6tmw

Reviewed By: neildhar

Differential Revision: D56482430

Pulled By: mattbfb

fbshipit-source-id: 903f63c5b3874a758551deb8e9ee8ff8f8bd19bb
  • Loading branch information
robandpdx authored and jpcloureiro committed Jul 16, 2024
1 parent 3815fec commit 512ee56
Showing 1 changed file with 571 additions and 0 deletions.
Loading

0 comments on commit 512ee56

Please sign in to comment.