moodlehq#128 - adding oracle credentials into databse class

jpahullo · Aug 11, 2021 · 053ffd4 · 053ffd4
1 parent 3b185a0
commit 053ffd4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -56,7 +56,6 @@ jobs:
             moodle-branch: 'MOODLE_311_STABLE'
             database: 'oci'
             extensions: 'mbstring, zip, gd, xmlrpc, soap, oci8'
-            dbcredentials: '--db-type oci --db-user moodle --db-pass m@0dl3ing --db-name moodle --db-host localhost'
 #          - php: '7.4'
 #            moodle-branch: 'MOODLE_310_STABLE'
 #            database: 'pgsql'
@@ -102,7 +101,7 @@ jobs:
         echo "NVM_DIR=$HOME/.nvm" >> $GITHUB_ENV
 
     - name: Install moodle-plugin-ci
-      run: moodle-plugin-ci install -vvv ${{ matrix.dbcredentials }}
+      run: moodle-plugin-ci install -vvv
       env:
         DB: ${{ matrix.database }}
         MOODLE_BRANCH: ${{ matrix.moodle-branch }}

diff --git a/src/Installer/Database/OracleDatabase.php b/src/Installer/Database/OracleDatabase.php
@@ -18,6 +18,10 @@
 class OracleDatabase extends AbstractDatabase
 {
     public $type = 'oci';
+    public $host = 'localhost';
+    public $user = 'moodle';
+    public $pass = 'm@0dl3ing';
+    public $name = 'XE';
 
     public function getCreateDatabaseCommand()
     {