Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code Structure #280

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Monirzadeh
Copy link
Contributor

@Monirzadeh Monirzadeh commented Sep 1, 2024

Hi @jovandeginste this PR is not finish yet but because i like to get your feedback i send this PR incomplete
this PR try to move most of the code base under internal for better organize. it helps for easier development over time (separate file bsaed of functionality)

TODO:

  • any code related to the UI go under internal/views like assets and translation
  • any code related to database go under internal/database
    • review database package
    • add database path configurable for development and keep it in /dev-data instead project root
  • any code related to basic functionality go to internal/core
  • review DockeFile and Makefile and be sure work with new path
  • do we need gofumpt use map for icons #291 (comment)

Things should done in other PR:

can you please run test for this PR so i can inform as soon as break CI too

@jovandeginste
Copy link
Owner

(tests have started)

@Monirzadeh
Copy link
Contributor Author

Monirzadeh commented Sep 1, 2024

@jovandeginste can run CI with every push automaticaly?

@jovandeginste
Copy link
Owner

Probably if you have merged pr's, because then you become a collaborator...

@jovandeginste
Copy link
Owner

You can run the tests locally?

@jovandeginste
Copy link
Owner

I'm wondering what code will not be under "internal"...?

@Monirzadeh
Copy link
Contributor Author

Monirzadeh commented Sep 2, 2024

You can run the tests locally?

Yes but somehow I get extra error in local + ci make things easer when it is ready for merge(maybe I should add more test)

Probably if you have merged pr's, because then you become a collaborator...

OK I will try to send another PR to improve ci and we can merge that so we can have better ci + run ci automatically on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants