-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup code Structure #280
base: master
Are you sure you want to change the base?
Conversation
(tests have started) |
@jovandeginste can run CI with every push automaticaly? |
Probably if you have merged pr's, because then you become a collaborator... |
You can run the tests locally? |
I'm wondering what code will not be under "internal"...? |
Yes but somehow I get extra error in local + ci make things easer when it is ready for merge(maybe I should add more test)
OK I will try to send another PR to improve ci and we can merge that so we can have better ci + run ci automatically on this PR |
3617b73
to
50a4a4b
Compare
Hi @jovandeginste this PR is not finish yet but because i like to get your feedback i send this PR incomplete
this PR try to move most of the code base under internal for better organize. it helps for easier development over time (separate file bsaed of functionality)
TODO:
internal/views
likeassets
andtranslation
internal/database
database
package/dev-data
instead project rootinternal/core
DockeFile
andMakefile
and be sure work with new pathgofumpt
use map for icons #291 (comment)Things should done in other PR:
more item will add to those todo list overtime
can you please run test for this PR so i can inform as soon as break CI too