forked from tshort/dactyl-keyboard
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix USB_C_WALL comment #113
Open
Schievel1
wants to merge
180
commits into
joshreve:master
Choose a base branch
from
Schievel1:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Four keys present, need walls two files
…generated trackball parts
…onversion of cadquery step to stl. (And to bypass Freecad crashing on file open dialog...)
…tter calculations on walls and allows thumb cluster to shift left and right by X columns.
… put all trackball-related funcs in the same damn spot in dactyl_manuform.py.
Updated btu socket to phat_btu_socket_w_access and phat_btu_socket_cutter.
Updated btu socket to phat_btu_socket_w_access and phat_btu_socket_cutter.
Fixed screw diameter and top depth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment is a bit misleading, it is actually
USB_C_WALL
notUSB-C-WALL
This took me hours to find out. :D