Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3]Sort order of fields relative to their actual location in the table #44486

Open
wants to merge 4 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #34501 .

Summary of Changes

in the element sorting field on the page, the STAGE field is at the very bottom, however, I remember exactly that we previously saved the order in this field relative to the actual location in the table (in this case, the stage line should be the second after ORDERING).

This pull request includes changes to the workflow-related sorting options in the content management system. The changes ensure that these options are only available when the workflow feature is enabled AND that they are positioned in the filter in the correct position

Workflow-related sorting options:

Conditional form field handling:

Conditional option inclusion:

Testing Instructions

Using Sample Data
Test 1. Enable workflows and observe in the sort filter dropdown the position of Stage Asc/Desc in the list
Test 2. Disable Workflows and observe that Stage Asc/Desc is not present in the list

Actual result BEFORE applying this Pull Request

  1. At the bottom of the list
  2. Not present

Expected result AFTER applying this Pull Request

  1. Near the top Directly below ordering to match the column order in the table
  2. Not present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <[email protected]>
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on d44ec3c

The fix works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

@Quy
Copy link
Contributor

Quy commented Nov 19, 2024

I have tested this item ✅ successfully on d44ec3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

@Quy
Copy link
Contributor

Quy commented Nov 19, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 19, 2024
@brianteeman
Copy link
Contributor Author

@Quy @Kostelano I forgot to do the same for the featured articles list - please can you additionally test that

@Quy
Copy link
Contributor

Quy commented Nov 20, 2024

I have tested this item ✅ successfully on d223bd3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

1 similar comment
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on d223bd3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants