Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Proof of Concept: Improve accessibility of quickicons #296

Closed
wants to merge 3 commits into from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jun 17, 2019

Pull Request for Issue #258 and #115 .

Improve UX and a11y for Quickicons

Quickicons are not always only buttons but show information. Update buttons have colours and texts as information. Checkin and Cache show numbers s the user is informed if an action is required..

For other icons as articles or users or plugins, the number often is not necessary and is disturbing for sreenreaders as is described in the issues.

Summary of Changes

The user can choose whether he wants to see the amount of items in a component or not.

This is a first step. Other Improvents will follow

@brianteeman
Copy link
Contributor

Looks much better now that we finally have dumped the meaningless numbers - although I still dont see the need/benefit for the numbers on the cache or checkin.

@chmst
Copy link
Contributor Author

chmst commented Jun 19, 2019

@brianteeman

although I still dont see the need/benefit for the numbers on the cache or checkin.

Checkin and cache are like the update buttons. There is nothing to do as long as a button is green or the number is 0. Only if a button is red or there are locked items / used cache, an action can be necessary

@brianteeman , @zwiastunsw Could you please listen to the screenreader now, as we have a sr-only text to the numbers?
If the user allows a number on a button, we add a text which says "number of ..: " before the number. So the user knows what the number means. In checkin and cache, the text will be changed.

@zwiastunsw There is still the issue open, that the screenreader does not count the Add- Buttons. This will be the next step.

@brianteeman
Copy link
Contributor

brianteeman commented Jun 19, 2019 via email

@brianteeman
Copy link
Contributor

The screen reader announces the text as follows

Number of Plugins colon 91
Plugins
visited link

I will leave it to @zwiastunsw to decide if thats ok.

@brianteeman
Copy link
Contributor

For the module options I would change the option strings to
Hide
Show
Show with count

@brianteeman
Copy link
Contributor

brianteeman commented Jun 19, 2019

And sorry to say but your js to show singular or plural is not correct for joomla as many languages have different strings dependant on the number - its not just a <=1. It doesn't event work in en-GB as it should be:

0 Articles
1 Article
2 Articles

Not

image

Maybe @infograf768 can advise on the correct way to do this so that it is usable by all languages

@zwiastunsw
Copy link
Contributor

  1. I have already explained why adding statistics to links is a bad idea. I have already explained why this solution is not accessible.
  2. We have here a typical example of a situation: first create an unnecessary problem and then look for a solution to an unnecessary problem. For a programmer and a designer it's a fairy tale. He has a chance to prove what a great designer and programmer he is. Only to whom and why should it prove it, we do not know?
  3. The new solution does not eliminate the problem of accessibility. On the contrary, it is a solution that excludes, not includes.
    We say to the sighted users: We have additional information accessible for you.
    For blind users we say: because this information for the visually impaired can be stressful, you can turn it off. There will be no stress, but there will also be no information.
  4. I have already written how to solve it: in a simple way - create a module of statistics. Leave QuickIcon module with its original function: a shortcut and only a shortcut to an important frequently used backend option.
  5. In this context, the grammatical problem is secondary. But it is also important. Polish is an inflectional language. The linguistic correctness requires an appropriate grammatical form, for example:
  • 0 artykułÓW,
  • 1 artykuł
  • 2 artykułY
  • 15 artykułÓW
  • 24 artykułY

Leaving the labels (Articles, Categories, etc.) in the same grammatical form will be a linguistic error. It is not solved by the form proposed for screen readers.

@brianteeman
Copy link
Contributor

Could not agree with you any stronger. You express so eloquently the issues.
There is an expression you can't put lipstick on a pig. No amount of lipstick will ever make these counters usable, accessible, useful or even beneficial. I am sorry that you have had to waste your time implementng a feature that was never a good idea. Just because everyone that said it was a bad idea was was excluded didn't magically make it a good idea.

@chmst
Copy link
Contributor Author

chmst commented Jun 20, 2019

Thank you for your time and for testing.
So we have really strong arguments for removing the numbers, a11y is more important than design.

@chmst chmst closed this Jun 20, 2019
@bembelimen bembelimen deleted the a11y-quickicons branch June 30, 2019 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants