-
Notifications
You must be signed in to change notification settings - Fork 23
Proof of Concept: Improve accessibility of quickicons #296
Conversation
Looks much better now that we finally have dumped the meaningless numbers - although I still dont see the need/benefit for the numbers on the cache or checkin. |
Checkin and cache are like the update buttons. There is nothing to do as long as a button is green or the number is 0. Only if a button is red or there are locked items / used cache, an action can be necessary @brianteeman , @zwiastunsw Could you please listen to the screenreader now, as we have a sr-only text to the numbers? @zwiastunsw There is still the issue open, that the screenreader does not count the Add- Buttons. This will be the next step. |
A cache of 256mb is as normal as a cache of 1mb. It depends on the size of
your site. Just because you login and see a number does not and should not
mean you need to clear the cache.
…On Wed, 19 Jun 2019, 16:15 Christiane Maier-Stadtherr, < ***@***.***> wrote:
@brianteeman <https://github.com/brianteeman>
although I still dont see the need/benefit for the numbers on the cache or
checkin.
Checkin and cache are like the update buttons. There is nothing to do as
long as a button is green or the number is 0. Only if a button is red or
there are locked items / used cache, an action can be necessary
@brianteeman <https://github.com/brianteeman> , @zwiastunsw
<https://github.com/zwiastunsw> Could you please listen to the
screenreader now, as we have a sr-only text to the numbers?
If the user allows a number on a button, we add a text which says "number
of ..: " before the number. So the user knows what the number means. In
checkin and cache, the text will be changed.
@zwiastunsw <https://github.com/zwiastunsw> There is still the issue
open, that the screenreader does not count the Add- Buttons. This will be
the next step.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#296?email_source=notifications&email_token=AAJ4P4KKH45PLFXOX7UJ3ODP3JEQDA5CNFSM4HYWSBZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCGKTA#issuecomment-503604556>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJ4P4MOP5GBSTIYFYFLOATP3JEQDANCNFSM4HYWSBZQ>
.
|
The screen reader announces the text as follows
I will leave it to @zwiastunsw to decide if thats ok. |
For the module options I would change the option strings to |
And sorry to say but your js to show singular or plural is not correct for joomla as many languages have different strings dependant on the number - its not just a <=1. It doesn't event work in en-GB as it should be:
Not Maybe @infograf768 can advise on the correct way to do this so that it is usable by all languages |
Leaving the labels (Articles, Categories, etc.) in the same grammatical form will be a linguistic error. It is not solved by the form proposed for screen readers. |
Could not agree with you any stronger. You express so eloquently the issues. |
Thank you for your time and for testing. |
Pull Request for Issue #258 and #115 .
Improve UX and a11y for Quickicons
Quickicons are not always only buttons but show information. Update buttons have colours and texts as information. Checkin and Cache show numbers s the user is informed if an action is required..
For other icons as articles or users or plugins, the number often is not necessary and is disturbing for sreenreaders as is described in the issues.
Summary of Changes
The user can choose whether he wants to see the amount of items in a component or not.
This is a first step. Other Improvents will follow