Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Responsive modals #67

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Responsive modals #67

wants to merge 10 commits into from

Conversation

ravisaxena23
Copy link

Pull Request for Issue # .

Summary of Changes

Modals in page builder were not responsive so i had made them responsive.
Before
Screenshot (19)
Screenshot (17)
Screenshot (18)

Testing Instructions

Open modal in any browser

Expected result

Screenshot (25)
Screenshot (24)

Actual result

Screenshot (25)
Screenshot (24)

Documentation Changes Required

No

@anuragteapot anuragteapot added the enhancement New feature or request label Jan 30, 2020
anuragteapot
anuragteapot previously approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@anuragteapot anuragteapot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work

@bembelimen
Copy link
Contributor

Thank you @ravisaxena23 for this PR.
Could you please remove the two "package-lock.json" files, they shouldn't be in this PR.

@ravisaxena23
Copy link
Author

package-lock.json

sir I can only see one package-lock.json can you please tell me which file should I remove

@ravisaxena23
Copy link
Author

Good Work

thank you

@bahl24
Copy link
Contributor

bahl24 commented Jan 30, 2020

package-lock.json

sir I can only see one package-lock.json can you please tell me which file should I remove

administrator/components/com_media/package-lock.json and package-lock.json

@ravisaxena23
Copy link
Author

package-lock.json

sir I can only see one package-lock.json can you please tell me which file should I remove

administrator/components/com_media/package-lock.json and package-lock.json

thank you sir

@ravisaxena23
Copy link
Author

@bahl24 @Anu1601CS please re-review

@bahl24
Copy link
Contributor

bahl24 commented Jan 30, 2020

package-lock.json is still there

@ravisaxena23
Copy link
Author

i removed this file administrator/components/com_media/package-lock.json should i remove both

@ravisaxena23
Copy link
Author

@bahl24 please look into it again

@ravisaxena23
Copy link
Author

ravisaxena23 commented Jan 31, 2020 •
edited
Loading

@bahl24 I used pritter. vs code does not give code sniffer exension for vue it is for php. also i have used pritter in all the files to make there format same. please look

@bahl24
Copy link
Contributor

bahl24 commented Jan 31, 2020

i removed this file administrator/components/com_media/package-lock.json should i remove both

Yes.

@ravisaxena23
Copy link
Author

@bahl24 please check this pr.

@ravisaxena23
Copy link
Author

old coding style @bahl24

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anuragteapot anuragteapot Awaiting requested review from anuragteapot

@bahl24 bahl24 Awaiting requested review from bahl24

@bembelimen bembelimen Awaiting requested review from bembelimen

@drmenzelit drmenzelit Awaiting requested review from drmenzelit

@HLeithner HLeithner Awaiting requested review from HLeithner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravisaxena23 @bembelimen @bahl24 @anuragteapot