feat pagebuilder module position from DB #46

bees4ever · 2019-09-05T14:14:46Z

Summary of Changes

Load a list of exiting module position for the pagebuilder.

Testing Instructions

Open the apodis template style
Switch to tab Page Builder
Click on the below Add button
Switch to Module Positions

Expected result

There should be a option list with module positions.

Actual result

There is an input field.

Documentation Changes Required

Not that I know.

drmenzelit · 2019-09-05T14:24:40Z

Thank you for your contribution @bees4ever , but if I see correctly the list is showing all existent positions from other templates, also from backend template. And that is not what we want to achieve. The idea of the page builder is to create a new template and also new module positions. Maybe is a combination of select list (but only with frontend positions) and an input field could be a solution.

bembelimen · 2019-09-05T14:49:25Z

Hello @bees4ever thank you for your suggestion. In general I like the idea where your PR is going, but I also think it's not there where it should be, because we have to solve some "bigger" challenges.

The reason for the input field was (and still is) that one never knows how many and which positions he/she wants to add. In Joomla! it's possible to add new positions on the fly (typing in the position name and press [enter]). So everyone can define their own field.

As @drmenzelit mentioned, your field lists all positions from all templates, but we only need (perhaps) a predefined list for the builder itself (position-1 to position-20) and a way to add manually new positions. The same combination field you added, but limited to the page builder.

On the other hand we still need a solution for the position selector in the module itself. There we should not only list the page builder default positions (position-1 to position-20) but also the manually added.

Perhaps you can extend your PR with a solution for this?

bees4ever · 2019-09-06T09:39:47Z

Hi @bembelimen,

roland-d explained me what you mean with the second point, I will start with this issue.

A draft of the "input & selection" feature is committed.

bembelimen · 2019-09-06T11:20:03Z

administrator/components/com_modules/Helper/ModulesHelper.php

+		}
+
+		return $customPosNames;
+	}


public static function getPageBuilderPositions($clientId) { $customPosNames = []; $db = Factory::getDbo(); $query = $db->getQuery(true) ->select($db->quoteName('params')) ->from($db->quoteName('#__template_styles')) ->where($db->quoteName('client_id') . ' = ' . (int) $clientId); $list = $db->setQuery($query)->loadObjectList(); foreach ($list as $param) { $paramsConf = json_decode($param->params, true); if ($paramsConf != null && isset($paramsConf["grid"])) { $paramsGridConf = json_decode($paramsConf["grid"], true); array_walk_recursive($paramsGridConf, function ($value, $key) use (&$customPosNames) { if ($key == "position_name") { $customPosNames[] = [ "value" => $value, "text" => $value, "disable" => false ]; } }); } } return $customPosNames; }

bembelimen · 2019-09-06T11:22:20Z

package.json

    "qrcode-generator": "^1.4.3",
+    "roboto-fontface": "^0.10.0",
+    "sass": "^1.23.0-module.beta.1",
+    "sass-loader": "^8.0.0",


Are you sure, that this new dependencies are needed?

Line 52 - 54 is indeed needed, because of the Vue JS Component I wrote to diesplay the module list in the page builder

bembelimen · 2019-09-06T11:23:09Z

package-lock.json

            },
            "yallist": {
              "version": "3.0.3",
              "bundled": true,
-              "dev": true
+              "dev": true,
+              "optional": true
            }
          }
        },


Please do not commit this file if there are no changes.

bembelimen · 2019-09-06T11:23:54Z

webpack.config.js

+    performance: {
+        hints: false
+    },
+    devtool: 'eval-source-map',


Do you need this new dependencies?

Is is also needed, because of the same reason

bembelimen · 2019-09-06T11:24:32Z

administrator/components/com_modules/Service/HTML/Modules.php

@@ -183,6 +183,8 @@ public function positions($clientId, $state = 1, $selectedPosition = '')
 		$customGroupText = Text::_('COM_MODULES_CUSTOM_POSITION');
 		$editPositions   = true;
 		$customPositions = ModulesHelper::getPositions($clientId, $editPositions);
+		$pagebuilderPositions = ModulesHelper::getPageBuilderPositions();


$pagebuilderPositions = ModulesHelper::getPageBuilderPositions($clientId);

bees4ever

As I can see, we need the package.json / webpack changes, to compile the Vue JS Components correctly.

bees4ever · 2019-09-06T12:08:49Z

webpack.config.js

+    performance: {
+        hints: false
+    },
+    devtool: 'eval-source-map',


Is is also needed, because of the same reason

bees4ever · 2019-09-06T12:09:12Z

administrator/components/com_modules/Service/HTML/Modules.php

@@ -183,6 +183,8 @@ public function positions($clientId, $state = 1, $selectedPosition = '')
 		$customGroupText = Text::_('COM_MODULES_CUSTOM_POSITION');
 		$editPositions   = true;
 		$customPositions = ModulesHelper::getPositions($clientId, $editPositions);
+		$pagebuilderPositions = ModulesHelper::getPageBuilderPositions();


Signed-off-by: Roland Dalmulder <[email protected]>

roland-d · 2020-02-09T12:13:40Z

Closing this in favor of #72

bees4ever added 2 commits September 5, 2019 15:56

feat pagebuilder module position from DB

57d7c21

code style

9451124

bees4ever added 4 commits September 5, 2019 17:15

load only positions from frontend

e89653d

render a list to a input - idea

a56609e

create component to handle input / selection

3cc8cc0

clean up code

4c84446

load pagebuilder module names

32c4777

bembelimen reviewed Sep 6, 2019

View reviewed changes

use \Registry instead of json_encode

f7649aa

bees4ever commented Sep 6, 2019

View reviewed changes

bees4ever added 2 commits September 9, 2019 11:02

clean up modal window

babf444

spelling issues

4907788

roland-d added a commit that referenced this pull request Feb 9, 2020

Code cleanup and review #46

d16066d

Signed-off-by: Roland Dalmulder <[email protected]>

roland-d added a commit that referenced this pull request Feb 9, 2020

Revert changes to the file docblock #46

49c93cb

Signed-off-by: Roland Dalmulder <[email protected]>

roland-d mentioned this pull request Feb 9, 2020

Show active module positions on Module element #72

Open

roland-d closed this Feb 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat pagebuilder module position from DB #46

feat pagebuilder module position from DB #46

bees4ever commented Sep 5, 2019

drmenzelit commented Sep 5, 2019

bembelimen commented Sep 5, 2019

bees4ever commented Sep 6, 2019

bembelimen Sep 6, 2019

bembelimen Sep 6, 2019

bees4ever Sep 6, 2019 •

edited

Loading

bembelimen Sep 6, 2019

bembelimen Sep 6, 2019

bees4ever Sep 6, 2019

bembelimen Sep 6, 2019

bees4ever Sep 6, 2019

bees4ever left a comment

bees4ever Sep 6, 2019

bees4ever Sep 6, 2019

roland-d commented Feb 9, 2020

feat pagebuilder module position from DB #46

feat pagebuilder module position from DB #46

Conversation

bees4ever commented Sep 5, 2019

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

drmenzelit commented Sep 5, 2019

bembelimen commented Sep 5, 2019

bees4ever commented Sep 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bees4ever Sep 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bees4ever left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roland-d commented Feb 9, 2020

bees4ever Sep 6, 2019 •

edited

Loading