support multiple og images

[lekoala]

this is a small patch to handle arrays from getOGImage

[jonom]

@lekoala I don't follow why getOGImage() should be able to handle an array? The method name implies a singular resource and OG only supports a single image per URL.

Thanks for the PR but I think that this is something you could solve in your own projects instead of this module by applying the logic you've used here in your own getOGImage() function.

If I've misunderstood the intention here feel free to re-open or add a comment!

[lekoala]

I assume this module is made to be compatible with https://github.com/tractorcow/silverstripe-opengraph
If you look there, you will see that the method getOGImage can return multiple images that will be represented by multiple og:image tags (as it should be, according to the docs https://developers.facebook.com/docs/sharing/opengraph/object-properties)

You can include multiple og:image tags if you have multiple resolutions available. If you update the image after publishing, use a new URL because images are cached based on the URL and might not update otherwise.

so basically, it would be great to support this feature in your module. My pull request is not perfect as it only takes into account the first image, but what would really be great is to actually support array from og image and make some kind of slider into the preview.

[jonom]

Okay, in that case could you make a couple of tweaks and then it looks good. Thanks

[jonom]

Please use tabs for indentation on html files

[jonom]

Could you change this to getFirstOGImage? I feel like that's more descriptive and less likely to confuse me later.

[jonom]

Side note, do you know if 'multiple resolutions' means multiple resolutions of the same image? That would be my assumption, but would be interesting if instead you can supply a variety of different images for sharers to choose from... Is that what you're implying regarding the slider comment? Do you know if Facebook or other sites lets you choose from a range of images if you supply more than one image OG tag?

[lekoala]

actually, that's how I used it : to allow choosing between multiple images. I discovered the actual documentation from Facebook when you asked about my changes :-)
So even if it seems that this is made from the same image in multiple resolutions, it can actually be used to provide multiple images that are not the same.

I'm working on the project that require this feature in one week or two I'll update the pull request at that time