Skip to content

Commit

Permalink
[ZEPPELIN-6099] Fix default ZEPPELIN_ANGULAR_WAR value
Browse files Browse the repository at this point in the history
### What is this PR for?
The misconfigured default `ZEPPELIN_ANGULAR_WAR` value is causing the failure to load the new UI web application files on development environment.
The new UI web apps are built into `ZEPPELIN_HOME/zeppelin-web-angular/dist/zeppelin`, but the default value lacks the `/zeppelin` postfix.
When developers run Zeppelin with `ZeppelinServer.main` method, it defaults to the incorrect `ZEPPELIN_ANGULAR_WAR` value, leading to failure to load the web apps.
*Note: This issue does not occur when Zeppelin is run using shell scripts in the `bin`, as they correctly set the `ZEPPELIN_ANGULAR_WAR` value.*

### What type of PR is it?
Bug Fix

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/6099

### How should this be tested?
* Build Zeppelin
* Run Zeppelin using `ZeppelinServer.main` method and connect to `http://localhost:8080`

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


Closes apache#4840 from tbonelee/fix-default-web-angular-config.

Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
tbonelee authored Sep 22, 2024
1 parent e20cbbc commit ac48cc2
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ public enum ConfVars {
ZEPPELIN_SSL_TRUSTSTORE_TYPE("zeppelin.ssl.truststore.type", null),
ZEPPELIN_SSL_TRUSTSTORE_PASSWORD("zeppelin.ssl.truststore.password", null),
ZEPPELIN_WAR("zeppelin.war", "zeppelin-web/dist"),
ZEPPELIN_ANGULAR_WAR("zeppelin.angular.war", "zeppelin-web-angular/dist"),
ZEPPELIN_ANGULAR_WAR("zeppelin.angular.war", "zeppelin-web-angular/dist/zeppelin"),
ZEPPELIN_WAR_TEMPDIR("zeppelin.war.tempdir", "webapps"),
ZEPPELIN_JMX_ENABLE("zeppelin.jmx.enable", false),
ZEPPELIN_JMX_PORT("zeppelin.jmx.port", 9996),
Expand Down

0 comments on commit ac48cc2

Please sign in to comment.